Skip to content

Add stat endpoint #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Add stat endpoint #113

merged 4 commits into from
Jan 29, 2025

Conversation

v9n
Copy link
Member

@v9n v9n commented Jan 29, 2025

fix #65

@@ -56,7 +56,7 @@ func (r *RpcServer) GetWallet(ctx context.Context, payload *avsproto.GetWalletRe
"factory", payload.FactoryAddress,
)

return r.engine.CreateSmartWallet(user, payload)
return r.engine.GetSmartWallet(user, payload)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed the external interface but didn't rename the internal API. just update here for consistent when working on this method now.

Copy link
Member

@chrisli30 chrisli30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v9n v9n merged commit 0cf46cc into main Jan 29, 2025
4 checks passed
@v9n v9n deleted the add-stat-endpoint branch January 29, 2025 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add task stat in GetWallet endpoint
2 participants